nonbinaryprogrammer commented on a change in pull request #6961: URL: https://github.com/apache/geode/pull/6961#discussion_r732287530
########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/RedisProperties.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.redis.internal; + + +public class RedisProperties { + /** System Property Names **/ + public static final String WRITE_TIMEOUT_SECONDS = "geode-for-redis-write-timeout-seconds"; + public static final String EXPIRATION_INTERVAL_SECONDS = + "geode-for-redis-expiration-interval-seconds"; + + + /** assumes that default is greater than or equal to minValue **/ + public static int getIntegerSystemProperty(String propName, int defaultValue, int minValue) { + int geodeValue = Integer.getInteger("geode." + propName, defaultValue); + int gemfireValue = Integer.getInteger("gemfire." + propName, defaultValue); + + if (geodeValue != defaultValue && geodeValue > minValue) { Review comment: indeed it should, thanks for catching that. I added the test for that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
