dschneider-pivotal commented on a change in pull request #6961:
URL: https://github.com/apache/geode/pull/6961#discussion_r726299931
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -132,6 +132,22 @@ public int getPort() {
return nettyRedisServer.getPort();
}
+ public int getConnectTimeoutMillis() {
Review comment:
do we need to expose all of these as attributes on GeodeRedisServer? I'm
just thinking that this could end up adding a bunch of gettors on
GeodeRedisServer. Are they only being exposed for testing? Could we instead ask
GeodeRedisServer for the underlying component (for example nettyRedisServer)
and then ask the component for its timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
