pivotal-jbarrett commented on a change in pull request #891:
URL: https://github.com/apache/geode-native/pull/891#discussion_r812444100
##########
File path: cppcache/src/PdxHelper.cpp
##########
@@ -137,28 +136,18 @@ void PdxHelper::serializePdx(
// so we don't know whether user has used those or not;; Can we do some
// trick here?
- auto createPdxRemoteWriter = [&]() -> PdxRemoteWriter {
- if (auto pd = pdxTypeRegistry->getPreserveData(pdxObject)) {
- auto mergedPdxType =
pdxTypeRegistry->getPdxType(pd->getMergedTypeId());
- return PdxRemoteWriter(output, mergedPdxType, pd, pdxTypeRegistry);
- } else {
- return PdxRemoteWriter(output, className, pdxTypeRegistry);
- }
- };
+ auto prw = cacheImpl->getPdxRemoteWriterFactory().create(
Review comment:
What this extracted into an pure virtual interface for the sole purpose
of integration testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
