dschneider-pivotal commented on a change in pull request #7456:
URL: https://github.com/apache/geode/pull/7456#discussion_r834804743
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
##########
@@ -554,12 +579,12 @@ private String
createCriticalThresholdLogMessage(MemoryEvent event, String event
}
public long getMaxMemory() {
- return heapUsageMonitor.getMaxMemory();
+ return heapUsageProvider.getMaxMemory();
}
@TestOnly
- public NotificationListener getHeapUsageMonitor() {
- return (MemoryPoolMXBeanHeapUsageProvider) heapUsageMonitor;
+ public NotificationListener getHeapUsageProvider() {
+ return (MemoryPoolMXBeanHeapUsageProvider) heapUsageProvider;
Review comment:
This method only exists to get an existing test:
MemoryMonitorIntegrationTest to work.
But I think getHeapUsageProvider will go away in the near future. This level
of detail should be tested by a unit test on MemoryPoolMXBeanHeapUsageProvider
not this integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
