dschneider-pivotal commented on a change in pull request #7456:
URL: https://github.com/apache/geode/pull/7456#discussion_r834800432
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryMonitor.java
##########
@@ -332,12 +331,7 @@ public void setLowMemory(final ScheduledThreadPoolExecutor
executor,
final boolean isLowMemory,
final long usedBytes,
final InternalCache cache) {
- if (cache.isQueryMonitorDisabledForLowMemory()) {
Review comment:
I was trying to clean some of the dependencies the
InternalResourceManager had with the InternalCache and thought it was safe to
remove this call because I thought if it was disabled then getQueryMonitor
would return null. But I was wrong. Even though it was disabled for low memory
monitoring it could still exist because of MAX_QUERY_EXECUTION_TIME being > 0.
And making this change broke ResourceManagerWithQueryMonitorDUnitTest. I just
pushed a new revision that fixes this test but instead of always asking the
cache if it is disabled, QueryMonitor is now told at construction time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
