kirklund commented on a change in pull request #7484:
URL: https://github.com/apache/geode/pull/7484#discussion_r835501835
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/size/ReflectionSingleObjectSizer.java
##########
@@ -89,62 +90,89 @@ public static long sizeof(Class<?> clazz) {
return sizeof(clazz, true);
}
+ public static long sizeof(Class<?> clazz, boolean roundResult) {
+ return sizeof(clazz, roundResult, unsafe);
+ }
+
+ @VisibleForTesting
Review comment:
I think you could leave off the annotation from these methods. Just have
them be package-private and don't worry if calling code is product or test.
It's a valid method either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
