demery-pivotal commented on a change in pull request #7484:
URL: https://github.com/apache/geode/pull/7484#discussion_r835534222
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/size/ReflectionSingleObjectSizer.java
##########
@@ -89,62 +90,89 @@ public static long sizeof(Class<?> clazz) {
return sizeof(clazz, true);
}
+ public static long sizeof(Class<?> clazz, boolean roundResult) {
+ return sizeof(clazz, roundResult, unsafe);
+ }
+
+ @VisibleForTesting
Review comment:
If the `Unsafe` were injected into a constructor, could the unit tests
exercise the instance methods instead of the formerly private static methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
