dschneider-pivotal commented on a change in pull request #7484:
URL: https://github.com/apache/geode/pull/7484#discussion_r835604358
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/size/ReflectionSingleObjectSizer.java
##########
@@ -89,62 +90,89 @@ public static long sizeof(Class<?> clazz) {
return sizeof(clazz, true);
}
+ public static long sizeof(Class<?> clazz, boolean roundResult) {
+ return sizeof(clazz, roundResult, unsafe);
+ }
+
+ @VisibleForTesting
Review comment:
This existing class already had no state and these new methods are
called by public static methods that this class exposes. This class has a
static initialize that sets the "unsafe" static field.
So it could be done but would require this entire class to be reworked to be
an instance.
I don't think it is worth taking on for the jdk17 work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
