codeconsole commented on code in PR #15127:
URL: https://github.com/apache/grails-core/pull/15127#discussion_r2427779629
##########
grails-gradle/model/src/main/groovy/grails/util/BuildSettings.groovy:
##########
@@ -253,7 +253,7 @@ class BuildSettings {
}
BASE_DIR = System.getProperty(APP_BASE_DIR) ? new
File(System.getProperty(APP_BASE_DIR)) :
(IOUtils.findApplicationDirectoryFile() ?: new File('.'))
GRAILS_APP_DIR_PRESENT = new File(BASE_DIR, 'grails-app').exists() ||
new File(BASE_DIR, 'Application.groovy').exists()
- TARGET_DIR = new File(BASE_DIR, 'build')
+ TARGET_DIR = System.getProperty(PROJECT_TARGET_DIR) ? new
File(BASE_DIR, System.getProperty(PROJECT_TARGET_DIR)) : new File(BASE_DIR,
'build')
Review Comment:
Setting it allows running multiple builds for various versions of Grails
simultaneously
```
./gradlew bootRun --project-prop buildDir=build-7.0.0-RC2
-PgrailsVersion=7.0.0-RC2
./gradlew bootRun --project-prop buildDir=build-7.0.0-SNAPSHOT
-PgrailsVersion=7.0.0-SNAPSHOT
```
not setting results in the pidfile being created in the same location and
throwing an exception.
@jdaugherty how is it breaking? if it is not set, it reverts to the way it
was previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
