codeconsole commented on code in PR #15127:
URL: https://github.com/apache/grails-core/pull/15127#discussion_r2430632467
##########
grails-gradle/model/src/main/groovy/grails/util/BuildSettings.groovy:
##########
@@ -253,7 +253,7 @@ class BuildSettings {
}
BASE_DIR = System.getProperty(APP_BASE_DIR) ? new
File(System.getProperty(APP_BASE_DIR)) :
(IOUtils.findApplicationDirectoryFile() ?: new File('.'))
GRAILS_APP_DIR_PRESENT = new File(BASE_DIR, 'grails-app').exists() ||
new File(BASE_DIR, 'Application.groovy').exists()
- TARGET_DIR = new File(BASE_DIR, 'build')
+ TARGET_DIR = System.getProperty(PROJECT_TARGET_DIR) ? new
File(BASE_DIR, System.getProperty(PROJECT_TARGET_DIR)) : new File(BASE_DIR,
'build')
Review Comment:
@jdaugherty because you shouldn't hard code `build`. It is not a guaranteed
directory name and customizable by gradle. This doesn't have to go in 7.0.0.
This is just trying to fix `java.io.FileNotFoundException:
/grails-demo/build/.grailspid (No such file or directory)` which is caused
because build directory is not automatically created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
