jdaugherty commented on code in PR #15127:
URL: https://github.com/apache/grails-core/pull/15127#discussion_r2430012231
##########
grails-gradle/model/src/main/groovy/grails/util/BuildSettings.groovy:
##########
@@ -253,7 +253,7 @@ class BuildSettings {
}
BASE_DIR = System.getProperty(APP_BASE_DIR) ? new
File(System.getProperty(APP_BASE_DIR)) :
(IOUtils.findApplicationDirectoryFile() ?: new File('.'))
GRAILS_APP_DIR_PRESENT = new File(BASE_DIR, 'grails-app').exists() ||
new File(BASE_DIR, 'Application.groovy').exists()
- TARGET_DIR = new File(BASE_DIR, 'build')
+ TARGET_DIR = System.getProperty(PROJECT_TARGET_DIR) ? new
File(BASE_DIR, System.getProperty(PROJECT_TARGET_DIR)) : new File(BASE_DIR,
'build')
Review Comment:
It's a breaking change b/c it didn't previously behave like this. We're
introducing a function here and I still am not clear why we need to support
this. Why do we need to support a custom build directory? We're trying to
remove BuildSettings.groovy completely in the longer run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
