Copilot commented on code in PR #15685:
URL: https://github.com/apache/grails-core/pull/15685#discussion_r3314836502
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedWithIdSpecifiedSpec.groovy:
##########
@@ -18,14 +18,15 @@
*/
package org.grails.datastore.gorm.mongo
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
import grails.persistence.Entity
import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
-class EmbeddedWithIdSpecifiedSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class EmbeddedWithIdSpecifiedSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [SystemCustomer, PreorderTreeNode,
MultiLevelKpi]
+ manager.addAllDomainClasses([SystemCustomer, PreorderTreeNode,
MultiLevelKpi])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/DisjunctionQuerySpec.groovy:
##########
@@ -18,20 +18,21 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Pet
import org.apache.grails.data.testing.tck.domains.PetType
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+
import spock.lang.Issue
-class DisjunctionQuerySpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class DisjunctionQuerySpec extends MongoDatastoreSpec {
def dogType
def catType
def birdType
void setupSpec() {
- manager.domainClasses += [Pet, PetType]
+ manager.addAllDomainClasses([Pet, PetType])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/GetAllSpec.groovy:
##########
@@ -18,19 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
-import grails.gorm.tests.Person
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Pet
+import grails.gorm.specs.Person
import org.apache.grails.data.testing.tck.domains.PetType
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
/**
* @author Graeme Rocher
*/
-class GetAllSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class GetAllSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet, Person, PetType]
+ manager.addAllDomainClasses([Pet, Person, PetType])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/InListQuerySpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import grails.gorm.tests.Pet
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
+import grails.gorm.specs.Pet
import org.apache.grails.data.testing.tck.domains.PetType
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+
import spock.lang.Issue
-class InListQuerySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class InListQuerySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet, Person, PetType]
+ manager.addAllDomainClasses([Pet, Person, PetType])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/NullifyPropertySpec.groovy:
##########
@@ -18,18 +18,18 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Pet
+import grails.gorm.specs.Person
/**
* Tests the nullification of properties
*/
-class NullifyPropertySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager>
{
+class NullifyPropertySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet, Person]
+ manager.addAllDomainClasses([Pet, Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ResultsWithGroovyCollectionMethodsSpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Plant
+
import spock.lang.Issue
/**
* Created by graemerocher on 16/04/14.
*/
-class ResultsWithGroovyCollectionMethodsSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class ResultsWithGroovyCollectionMethodsSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/SchemalessSpec.groovy:
##########
@@ -18,13 +18,13 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class SchemalessSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Plant
+
+class SchemalessSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/SessionCachingSpec.groovy:
##########
@@ -18,16 +18,16 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
/**
* Tests related to caching of entities.
*/
-class SessionCachingSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class SessionCachingSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/EmbeddedHasManyWithBeforeUpdateSpec.groovy:
##########
@@ -18,15 +18,16 @@
*/
package org.grails.datastore.gorm.mongo
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
import grails.persistence.Entity
import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.bson.types.ObjectId
-class EmbeddedHasManyWithBeforeUpdateSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class EmbeddedHasManyWithBeforeUpdateSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [User, UserAddress]
+ manager.addAllDomainClasses([User, UserAddress])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoResultsListIndexSpec.groovy:
##########
@@ -18,17 +18,17 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
/**
* @author Graeme Rocher
*/
-class MongoResultsListIndexSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class MongoResultsListIndexSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/LikeQuerySpec.groovy:
##########
@@ -18,14 +18,14 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class LikeQuerySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Pet
+
+class LikeQuerySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet]
+ manager.addAllDomainClasses([Pet])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/NegateInListSpec.groovy:
##########
@@ -18,14 +18,14 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class NegateInListSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Person
+
+class NegateInListSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/HintQueryArgumentSpec.groovy:
##########
@@ -18,18 +18,18 @@
*/
package org.grails.datastore.gorm.mongo
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
import com.mongodb.MongoException
import com.mongodb.MongoQueryException
import grails.gorm.CriteriaBuilder
import grails.gorm.DetachedCriteria
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import grails.gorm.specs.Person
-class HintQueryArgumentSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class HintQueryArgumentSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/OneToOneIntegritySpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Face
-import grails.gorm.tests.Nose
-import grails.gorm.tests.Person
-import grails.gorm.tests.Pet
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Face
+import grails.gorm.specs.Nose
+import grails.gorm.specs.Person
+import grails.gorm.specs.Pet
+
import org.bson.Document
-class OneToOneIntegritySpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class OneToOneIntegritySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person, Pet, Face, Nose]
+ manager.addAllDomainClasses([Person, Pet, Face, Nose])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/OrderWithPaginationSpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Plant
+
import spock.lang.Issue
/**
* Created by graemerocher on 14/03/14.
*/
-class OrderWithPaginationSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class OrderWithPaginationSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy:
##########
@@ -18,29 +18,29 @@
*/
package org.grails.datastore.gorm.mongo
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
import com.mongodb.MongoQueryException
import com.mongodb.ReadConcern
import com.mongodb.WriteConcern
import grails.gorm.CriteriaBuilder
import grails.gorm.DetachedCriteria
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.grails.datastore.mapping.mongo.MongoCodecSession
import spock.lang.Ignore
/**
* Created by graemerocher on 03/02/2017.
*/
-class ReadConcernArgumentSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class ReadConcernArgumentSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [grails.gorm.tests.Person]
+ manager.addAllDomainClasses([grails.gorm.specs.Person])
Review Comment:
`manager.addAllDomainClasses(...)` is called, but `GrailsDataTckManager`
(and `GrailsDataMongoTckManager`) do not define this method in this branch.
This will throw a `MissingMethodException` when `setupSpec()` runs. Use
`manager.domainClasses.addAll([...])` (or `+=`) unless this PR also introduces
the helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
