jamesfredley commented on code in PR #15685:
URL: https://github.com/apache/grails-core/pull/15685#discussion_r3314890102
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/InListQuerySpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import grails.gorm.tests.Pet
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
+import grails.gorm.specs.Pet
import org.apache.grails.data.testing.tck.domains.PetType
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+
import spock.lang.Issue
-class InListQuerySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class InListQuerySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet, Person, PetType]
+ manager.addAllDomainClasses([Pet, Person, PetType])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/LikeQuerySpec.groovy:
##########
@@ -18,14 +18,14 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class LikeQuerySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Pet
+
+class LikeQuerySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet]
+ manager.addAllDomainClasses([Pet])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/MongoResultsListIndexSpec.groovy:
##########
@@ -18,17 +18,17 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
/**
* @author Graeme Rocher
*/
-class MongoResultsListIndexSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class MongoResultsListIndexSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/NegateInListSpec.groovy:
##########
@@ -18,14 +18,14 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class NegateInListSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Person
+
+class NegateInListSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/NullifyPropertySpec.groovy:
##########
@@ -18,18 +18,18 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Pet
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Pet
+import grails.gorm.specs.Person
/**
* Tests the nullification of properties
*/
-class NullifyPropertySpec extends GrailsDataTckSpec<GrailsDataMongoTckManager>
{
+class NullifyPropertySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Pet, Person]
+ manager.addAllDomainClasses([Pet, Person])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/OneToOneIntegritySpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Face
-import grails.gorm.tests.Nose
-import grails.gorm.tests.Person
-import grails.gorm.tests.Pet
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Face
+import grails.gorm.specs.Nose
+import grails.gorm.specs.Person
+import grails.gorm.specs.Pet
+
import org.bson.Document
-class OneToOneIntegritySpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class OneToOneIntegritySpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person, Pet, Face, Nose]
+ manager.addAllDomainClasses([Person, Pet, Face, Nose])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/OrderWithPaginationSpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Plant
+
import spock.lang.Issue
/**
* Created by graemerocher on 14/03/14.
*/
-class OrderWithPaginationSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class OrderWithPaginationSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
