jamesfredley commented on code in PR #15685:
URL: https://github.com/apache/grails-core/pull/15685#discussion_r3314890824
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ReadConcernArgumentSpec.groovy:
##########
@@ -18,29 +18,29 @@
*/
package org.grails.datastore.gorm.mongo
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
import com.mongodb.MongoQueryException
import com.mongodb.ReadConcern
import com.mongodb.WriteConcern
import grails.gorm.CriteriaBuilder
import grails.gorm.DetachedCriteria
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
import org.grails.datastore.mapping.mongo.MongoCodecSession
import spock.lang.Ignore
/**
* Created by graemerocher on 03/02/2017.
*/
-class ReadConcernArgumentSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class ReadConcernArgumentSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [grails.gorm.tests.Person]
+ manager.addAllDomainClasses([grails.gorm.specs.Person])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/ResultsWithGroovyCollectionMethodsSpec.groovy:
##########
@@ -18,18 +18,19 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Plant
+
import spock.lang.Issue
/**
* Created by graemerocher on 16/04/14.
*/
-class ResultsWithGroovyCollectionMethodsSpec extends
GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class ResultsWithGroovyCollectionMethodsSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/SchemalessSpec.groovy:
##########
@@ -18,13 +18,13 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Plant
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
-class SchemalessSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+import grails.gorm.specs.Plant
+
+class SchemalessSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Plant]
+ manager.addAllDomainClasses([Plant])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
##########
grails-data-mongodb/core/src/test/groovy/org/grails/datastore/gorm/mongo/SessionCachingSpec.groovy:
##########
@@ -18,16 +18,16 @@
*/
package org.grails.datastore.gorm.mongo
-import grails.gorm.tests.Person
-import org.apache.grails.data.mongo.core.GrailsDataMongoTckManager
-import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec
+import org.apache.grails.data.mongo.core.MongoDatastoreSpec
+
+import grails.gorm.specs.Person
/**
* Tests related to caching of entities.
*/
-class SessionCachingSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> {
+class SessionCachingSpec extends MongoDatastoreSpec {
void setupSpec() {
- manager.domainClasses += [Person]
+ manager.addAllDomainClasses([Person])
Review Comment:
Fixed in b5a7aa7625 - good catch. The `addAllDomainClasses` helper only
exists in #15683 (PR-C), not on 8.0.x. The setupSpec calls were inherited from
the staging branch where both changes coexisted. Converted to
`manager.domainClasses.addAll(...)` to make PR-E self-contained against 8.0.x.
Verified with `./gradlew :grails-data-mongodb-core:compileTestGroovy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
