borinquenkid commented on code in PR #15731:
URL: https://github.com/apache/grails-core/pull/15731#discussion_r3408713205
##########
gradle/functional-test-config.gradle:
##########
@@ -32,7 +72,8 @@ configurations.configureEach {
//TODO: This does not handle libraries that are both test
fixtures & a libraries like grails-data-mongodb,
// see grails-test-examples-mongodb-base, &
grails-test-examples-mongodb-hibernate5 for project() workaround
if (possibleProject.name == 'grails-bom') {
- substitute module(substitutedArtifact) using
platform(project(':grails-bom'))
+ def targetBom = redirectBomToH7 ? ':grails-hibernate7-bom'
: ':grails-bom'
+ substitute module(substitutedArtifact) using
platform(project(targetBom))
Review Comment:
"Hey [@jdaugherty](https://github.com/jdaugherty), that makes total sense.
In an OSS context, hidden classpath manipulation like this easily rots if left
unchecked, and I agree we don't want people troubleshooting brittle IDE syncs
locally.
Here is compromise so we can hit our end-of-June release target for
Hibernate 7 parity without abandoning your architectural goal:
Fail-Safe Logging: I will add an explicit, loud deprecation warning or a
hardcoded TODO block directly above this substitution in
functional-test-config.gradle tracking its removal.
Immediate Post-Release Issue: I'll open a tracking issue right now to
completely untangle this layer by cloning the apps into a clean directory
structure.
Given that I want to completely drop Hibernate 5 support in the near future
anyway, duplicating the entire H5 test matrix right this second might end up
being throwaway work. Can we use this substitution as a temporary bridge to
unblock the June release gate, with the explicit agreement that the cleanup
issue is the immediate next priority?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
