jamesfredley commented on code in PR #15731:
URL: https://github.com/apache/grails-core/pull/15731#discussion_r3424396571
##########
gradle/functional-test-config.gradle:
##########
@@ -32,7 +72,8 @@ configurations.configureEach {
//TODO: This does not handle libraries that are both test
fixtures & a libraries like grails-data-mongodb,
// see grails-test-examples-mongodb-base, &
grails-test-examples-mongodb-hibernate5 for project() workaround
if (possibleProject.name == 'grails-bom') {
- substitute module(substitutedArtifact) using
platform(project(':grails-bom'))
+ def targetBom = redirectBomToH7 ? ':grails-hibernate7-bom'
: ':grails-bom'
+ substitute module(substitutedArtifact) using
platform(project(targetBom))
Review Comment:
Agreed, and done. Removed the BOM substitution entirely in 83e5ebd454.
`gradle/functional-test-config.gradle` is back to the base-branch version:
no `redirectBomToH7`, no `grails-bom` -> `grails-hibernate7-bom` redirect, no
`grails-data-hibernate5` -> `grails-data-hibernate7` swap, and no
`hibernate-ehcache`/`jboss-transaction` excludes or H7 BOM platform attachment.
The `hibernate-version` matrix is also gone from the general `functional`
workflow job, so there's no hidden classpath manipulation and
`dependencies`/`dependencyInsight` debugging behaves normally again. The
default lane is just Hibernate 5 as before; the existing `hibernate7Functional`
job still runs the H7-specific example apps and now gates `publish`.
To keep the H7 coverage we were missing without a switch, the
version-agnostic GORM behavior now lives in the shared TCK
(`grails-datamapping-tck`), which both `grails-data-hibernate5` and
`grails-data-hibernate7` already run via the `GrailsDataTckManager`
ServiceLoader. The same specs therefore execute natively on both lines, Gradle
caching stays intact, and coverage reports clearly attribute to each module.
First batch landed in `FindWhereSpec` and `GormEnhancerSpec`
(findWhere/findAllWhere null matching, findWhere single-result limiting, and
getAll order preservation including convertible String ids). All six new tests
pass on both Hibernate 5.6 and 7.4. Remaining relevant coverage will follow the
same TCK-first pattern, with dedicated H7 example specs only where behavior
genuinely cannot move to the TCK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
