jdaugherty commented on code in PR #15731:
URL: https://github.com/apache/grails-core/pull/15731#discussion_r3414024661


##########
gradle/functional-test-config.gradle:
##########
@@ -32,7 +72,8 @@ configurations.configureEach {
                 //TODO: This does not handle libraries that are both test 
fixtures & a libraries like grails-data-mongodb,
                 // see grails-test-examples-mongodb-base, & 
grails-test-examples-mongodb-hibernate5 for project() workaround
                 if (possibleProject.name == 'grails-bom') {
-                    substitute module(substitutedArtifact) using 
platform(project(':grails-bom'))
+                    def targetBom = redirectBomToH7 ? ':grails-hibernate7-bom' 
: ':grails-bom'
+                    substitute module(substitutedArtifact) using 
platform(project(targetBom))

Review Comment:
   I'm strongly a -1 on this.  People will just ignore the depreciation and it 
doesn't solve our actual problem.  The majority of the work I've done with 
Grails is dependency debugging - probably over 50% of my time has been spent on 
it.  This completely breaks that workflow.  By substituting arbitrarily, we now 
have to populate that option throughout our workflows to be able to debug.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to