jamesfredley commented on PR #15730: URL: https://github.com/apache/grails-core/pull/15730#issuecomment-4794461018
Addressed the remaining feedback from @jdaugherty and pushed `a5a70ec91b`. What changed: - `GrailsDependencyVersions` now fails fast when an imported BOM cannot be resolved, including the failing BOM coordinates and preserving the original cause. - `GrailsDependencyVersionsSpec` now asserts that fail-fast behavior, so a broken imported BOM cannot silently produce incomplete CLI dependency management. - The PR description has been updated at the top to reflect the current behavior, including the fail-fast imported BOM handling. - Replied to the three inline review comments and marked those threads resolved. Verification: - `./gradlew :grails-shell-cli:test --tests "org.grails.cli.boot.GrailsDependencyVersionsSpec"` passed. - `./gradlew :grails-shell-cli:test --no-build-cache` passed. - Oracle review gate returned GREEN for the exact pushed diff. Note: the first full `:grails-shell-cli:test` run executed the tests successfully but failed afterward in `jacocoTestReport` because another Java process held the Gradle journal cache lock. Rerunning with `--no-build-cache` completed successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
