jamesfredley commented on code in PR #15730:
URL: https://github.com/apache/grails-core/pull/15730#discussion_r3523539017


##########
grails-shell-cli/src/main/groovy/org/grails/cli/boot/GrailsDependencyVersions.groovy:
##########
@@ -85,27 +86,62 @@ class GrailsDependencyVersions implements 
DependencyManagement {
 
     @CompileDynamic
     void addDependencyManagement(GPathResult pom) {
-        versionProperties = pom.properties.'*'.collectEntries { [(it.name()): 
it.text()] }

Review Comment:
   Addressed in b18a036167. GrailsDependencyVersions now resolves BOMs through 
Maven DefaultModelBuilder instead of custom XML traversal, while preserving 
versionProperties from imported BOM models with first-writer-wins semantics for 
create-app.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to