borinquenkid commented on code in PR #15972: URL: https://github.com/apache/grails-core/pull/15972#discussion_r3564720021
########## gradle.properties: ########## @@ -40,6 +41,9 @@ jnrPosixVersion=3.1.20 joddWotVersion=3.3.8 joptSimpleVersion=5.0.4 jspApiVersion=4.0.0 +logbackClassicVersion=1.4.14 +neo4jDriverVersion=4.4.13 Review Comment: Correction to my earlier reply, per @jdaugherty's follow-up: the purpose of `validateDependencyVersions` is to guarantee the BOM manages the *latest* winning version, so end-app consumers don't get uncontrolled transitive upgrades — meaning this genuinely does need to be BOM-managed, not left as a documented-but-unmanaged exception. Fixed properly in 40b7aa1bf1: `neo4j-java-driver` is now declared in `dependencies.gradle`'s `customBomVersions`/`customBomDependencies` block with a `strictly` constraint — the same mechanism this repo already uses to pin `liquibase`/`hibernate` versions below what Spring Boot's BOM would otherwise offer. (I first tried excluding `org.neo4j.driver` from `grails-bom`'s `spring-boot-bom` platform inclusion, but verified via dependency-tree inspection that `exclude` doesn't actually strip individual constraint entries pulled in through a `platform()` dependency — `strictly` is what actually wins.) Verified: `grails-data-mongodb-docs:validateDependencyVersions` now passes, the full repo-wide check is clean (only the pre-existing, unrelated `commons-codec` issue remains), and the Neo4j modules still compile against the new resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
