borinquenkid commented on code in PR #15972:
URL: https://github.com/apache/grails-core/pull/15972#discussion_r3564862625
##########
settings.gradle:
##########
@@ -397,6 +414,16 @@
project(':grails-test-examples-mongodb-test-data-service').projectDir = new File
include 'grails-test-examples-mongodb-gson-templates'
project(':grails-test-examples-mongodb-gson-templates').projectDir = new
File(settingsDir, 'grails-test-examples/mongodb/gson-templates')
+// functional tests - neo4j examples
+include 'grails-test-examples-neo4j-grails3-neo4j'
Review Comment:
Follow-up — this is now fully addressed, on a per-item basis:
1. **JVM args** — checked (should have said this the first time instead of
skipping it): all three example apps already declare `tasks.withType(Test) {
jvmArgs += ['--add-opens', 'java.base/java.lang=ALL-UNNAMED', '--add-opens',
'java.base/sun.nio.ch=ALL-UNNAMED'] }` in their own `build.gradle`, same
pattern as the core module. Not inherited from the shared config, but present
and correctly wired.
2. **Dedicated CI job + publish gating** — added in a6aa7bd8cd.
`neo4jFunctional` mirrors `hibernate5Functional`/`hibernate7Functional` (no
service-container/version matrix needed since Neo4j is embedded), wired into
`publish`'s `needs`/`if` gate. Left out of `publishMicronaut`'s gate since
Neo4j has no Micronaut-specific published artifact — matches how
`hibernate7Functional` is already excluded there too. Also added
`-PskipNeo4jTests` to the default `functional` job so the slow
embedded-Neo4j-3.5 boot doesn't run twice.
One related thing surfaced while wiring this that's worth flagging, though
it's pre-existing and not something I introduced: `grails-data-neo4j`'s own
plugin-module tests don't apply any test-config gate at all (no `apply from:`
for a test-config file), so `-PonlyNeo4jTests`/`-PskipNeo4jTests` have no
effect on them — they always run regardless. Checked, and
`grails-data-mongodb`'s and `grails-data-hibernate5`'s plugin modules have the
identical gap, so it's a repo-wide pattern, not specific to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
