borinquenkid commented on code in PR #15972:
URL: https://github.com/apache/grails-core/pull/15972#discussion_r3564903479
##########
settings.gradle:
##########
@@ -397,6 +414,16 @@
project(':grails-test-examples-mongodb-test-data-service').projectDir = new File
include 'grails-test-examples-mongodb-gson-templates'
project(':grails-test-examples-mongodb-gson-templates').projectDir = new
File(settingsDir, 'grails-test-examples/mongodb/gson-templates')
+// functional tests - neo4j examples
+include 'grails-test-examples-neo4j-grails3-neo4j'
+project(':grails-test-examples-neo4j-grails3-neo4j').projectDir = new
File(settingsDir, 'grails-test-examples/neo4j/grails3-neo4j')
Review Comment:
Follow-up, split by item:
1. **Forge integration** — restored in e2e4522931. Turned out much smaller
than I first assumed: the removal commit (d214a06fb2) explicitly said it would
come back "when Grails Data for Neo4j has been updated for Grails 7 or 8" -
which is exactly this PR. Brought back `Neo4jGorm.java` (as a
`GormOneOfFeature` sibling of `MongoGorm`), the `NEO4J` entry in the `GormImpl`
enum, `Neo4JGormSpec`, and the mutual-exclusion test that was dropped from
`MongoGormSpec` alongside it - all updated for the
`org.apache.grails:grails-data-neo4j` coordinate instead of the old
`org.grails.plugins:neo4j`. Every other `GormImpl` consumer (CLI
converter/candidates, API DTOs, `ContextFactory`) iterates `.values()` or
passes the enum through generically, so nothing else needed a case added.
Verified: `Neo4JGormSpec` (4/4) and `MongoGormSpec` (5/5) pass.
2. **Naming convention** — partially addressed already:
`gorm-neo4j-spring-boot` → `grails-data-neo4j-spring-boot` landed in the
earlier rename commit (d580d61465). The bigger piece -
`grails-datastore-gorm-neo4j` → `grails-data-neo4j-core` (matching
`grails-data-mongodb-core`/`grails-data-hibernate5-core`) plus the
`grails3-neo4j`/`grails3-neo4j-hibernate` example-app names →
`base`/`hibernate5` (matching mongodb's actual layout) - is still open. That
one touches 12 files including the module with the still-pending CodeNarc
cleanup, so deliberately sequencing it after that rather than compounding two
risky changes in the same module at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
