codeconsole commented on PR #16414: URL: https://github.com/apache/grails-core/pull/16414#issuecomment-6007979350
@borinquenkid Addressed: - 9b0c6c1304: `JsonMapperSupport` no longer calls `_serializationContext()`. It takes the context from `ObjectMapper.acceptJsonFormatVisitor`, which creates it with `_serializationContext()` and passes it to the visitor, so output is unchanged. - 208977c9c4: no bypass. The converter writes with a copy of the application's `JsonMapper` whose serializers hand each value they write back to the converter. `registerObjectMarshaller`, enum names and the circular-reference behaviours therefore apply inside a module serializer. The application's own mapper is unchanged. Your repro and the cycle cases are in `JsonMapperRenderingSpec`. - a2dc99db23: the domain-class module you described. `DomainClassSerializer` renders domain classes as `DomainClassMarshaller` did, and Grails registers it with the application's `JsonMapper` as a `JacksonModule` bean. `jsonMapper.writeValueAsString(book)` and a `@RestController` returning a domain object now render as `render ... as JSON` does. `DomainClassMarshaller` hands instances to it with the converter's includes/excludes, and its protected hooks still apply. Beans, enums, collections and maps still go through Grails marshallers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
