jdaugherty commented on PR #16631: URL: https://github.com/apache/grails-core/pull/16631#issuecomment-6402514432
@jamesfredley both items from your last review are fixed in b8c346b48c. It is still a single commit. - **Programmatic statement inspector:** on Hibernate 7, the installer now wraps an inspector a `configClass` sets with `setStatementInspector`, and installs the wrapper the same way. When the property also names an inspector, the wrapper runs the one set on the configuration, as Hibernate does. Hibernate 5.6's `Configuration` has no such setter, so on Hibernate 5 a `configClass` can set an inspector only through the configuration's properties, which the installer already wraps. A Hibernate 5 test now covers that case. - **Quoted names in the collapser:** clause matching now skips names quoted with double quotes, backticks or brackets, including doubled closing quotes. `update "order set lines" ...` and `update "order set headers" ...` now stay two statements. Comment and whitespace removal also leave quoted names as written. The new tests fail on the previous code. The Hibernate 5 and 7 query-tail specs, the CLI query-tail specs and CodeNarc pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
