jdaugherty commented on PR #16771:
URL: https://github.com/apache/grails-core/pull/16771#issuecomment-6523524411
The open thread on `heldElement` is fixed, with the reply inline. Three
commits on top of 66a010e175:
- 8b637a920f: for a key in brackets with a dot in it, the held map takes the
field from the flat element every time it is written, the one-liner from the
thread. The `/api/v1.0/**` rows of the two new tests fail at 66a010e175.
- 3d3339b73a: the field just written is taken from the maps the merge wrote
it into, for every key, through `storedValue`, and the flat element is no
longer read for it. That also resolves a placeholder in a field of a dotted
bracketed key: `config.grails.cors.mappings['/api/v1.0/**'].maxAge` read `${x}`
where `[/api/**]` read `resolved`. The `/api/v1.0/**` rows of the placeholder
test fail at 8b637a920f.
- b400db269b, for the nit: the two tests that start with "a dotted key
inside a nested map" are back where 7.0.x has them, so
`PropertySourcesConfigSpec` differs from 7.0.x by added lines only.
`NavigableMapSpec`, `PropertySourcesConfigSpec`, `PropertySourceConfigSpec`,
`NavigableMapPropertySourceSpec`, `GrailsCorsConfigurationSpec` and `codeStyle`
for `grails-bootstrap` and `grails-core` pass locally; the full suites run on
CI. Could you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
