paulk-asert commented on a change in pull request #1171: GROOVY-9416: Avoid unnecessary looking up non default import classes … URL: https://github.com/apache/groovy/pull/1171#discussion_r382940149
########## File path: src/test/org/codehaus/groovy/runtime/FileAppendTest.groovy ########## @@ -19,6 +19,7 @@ package org.codehaus.groovy.runtime import groovy.test.GroovyTestCase +import groovy.lang.DummyGStringBase Review comment: I am not sure I like ever having to import something from groovy.lang or groovy.util. We have IDEs and codenarc checks that are going to complain too. I would expect just a slower path in those cases if not in a cache. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
