danielsun1106 commented on a change in pull request #1171: GROOVY-9416: Avoid unnecessary looking up non default import classes … URL: https://github.com/apache/groovy/pull/1171#discussion_r382956129
########## File path: src/test/org/codehaus/groovy/runtime/FileAppendTest.groovy ########## @@ -19,6 +19,7 @@ package org.codehaus.groovy.runtime import groovy.test.GroovyTestCase +import groovy.lang.DummyGStringBase Review comment: Understood. In fact the classes are not real groovy-core classes, I call them fake core classes ;-) I am not sure whether we should support declaring arbitrary classes under groovy-core packages and importing by default. AFAIK, Java does not allow this kind of declaration... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
