blackdrag commented on a change in pull request #1171: GROOVY-9416: Avoid
unnecessary looking up non default import classes …
URL: https://github.com/apache/groovy/pull/1171#discussion_r382986763
##########
File path: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java
##########
@@ -106,6 +141,15 @@
return result;
}
+ @Override
+ public boolean resolveFromDefaultImports(ResolveVisitor resolveVisitor,
final ClassNode type) {
Review comment:
Actually, ClassFinder my have handling for module-info and jrt, but it
would work just fine under Java8, if you added handling for jar urls I think.
Are you using methods/classes in there that are Java9 specific? Did not spot
any, but I was not looking too much into details.
Anyway, my thinking is that the plugins should not just bring compiler
classes into them if not needed. In fact we should move them out there as much
as possible. The Java5 generics code was a bit different since you needed to
produce AST and required Java5 specific classes to produce it. But now that is
no longer the case and a good portion of the methods should be no longer in a
plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
