[ 
https://issues.apache.org/jira/browse/GROOVY-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18044209#comment-18044209
 ] 

ASF GitHub Bot commented on GROOVY-8373:
----------------------------------------

blackdrag opened a new pull request, #2352:
URL: https://github.com/apache/groovy/pull/2352

   The filterLine method returns a Writable whose writeTo method reads from a 
BufferedReader but never closes it, causing the underlying file handle to 
remain open and cause resource leaks.
   
   This fix wraps the filtering logic in writeTo within a try-finally block to 
ensure the BufferedReader is closed after use.




> File.filterLine leaves hanging Reader
> -------------------------------------
>
>                 Key: GROOVY-8373
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8373
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-jdk
>            Reporter: Tim Yates
>            Priority: Trivial
>
> Looks like the default method for {{new File('.').filterLine}} creates a 
> {{newReader}} which is never closed, nor is it accessible for the user to 
> close it themselves.
> https://github.com/apache/groovy/blob/2d9c467ade68da0e3e73e64c4db7f29d742162f9/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java#L2386



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to