[
https://issues.apache.org/jira/browse/GROOVY-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18044213#comment-18044213
] ASF GitHub Bot commented on GROOVY-8373: ---------------------------------------- codecov-commenter commented on PR #2352: URL: https://github.com/apache/groovy/pull/2352#issuecomment-3638278217 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2352?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.0065%. Comparing base ([`cc8bc3e`](https://app.codecov.io/gh/apache/groovy/commit/cc8bc3e408f5bc7a6779c70f11a29a4cffdf04a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f3b6fdd`](https://app.codecov.io/gh/apache/groovy/commit/f3b6fdd794171fe8992b4024f881dec1c974f97a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2352 +/- ## ================================================== - Coverage 67.0080% 67.0065% -0.0014% + Complexity 29357 29355 -2 ================================================== Files 1382 1382 Lines 116619 116620 +1 Branches 20444 20444 ================================================== - Hits 78144 78143 -1 - Misses 32039 32040 +1 - Partials 6436 6437 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2352?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...a/org/codehaus/groovy/runtime/IOGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2352?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FIOGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvSU9Hcm9vdnlNZXRob2RzLmphdmE=) | `89.7638% <100.0000%> (+0.0269%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2352/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > File.filterLine leaves hanging Reader > ------------------------------------- > > Key: GROOVY-8373 > URL: https://issues.apache.org/jira/browse/GROOVY-8373 > Project: Groovy > Issue Type: Bug > Components: groovy-jdk > Reporter: Tim Yates > Priority: Trivial > > Looks like the default method for {{new File('.').filterLine}} creates a > {{newReader}} which is never closed, nor is it accessible for the user to > close it themselves. > https://github.com/apache/groovy/blob/2d9c467ade68da0e3e73e64c4db7f29d742162f9/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java#L2386 -- This message was sent by Atlassian Jira (v8.20.10#820010)
