[
https://issues.apache.org/jira/browse/GROOVY-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18044463#comment-18044463
]
ASF GitHub Bot commented on GROOVY-8373:
----------------------------------------
eric-milles commented on PR #2352:
URL: https://github.com/apache/groovy/pull/2352#issuecomment-3642519223
The `void filterLine(Reader,Writer,...` variant explicitly states that it
closes the reader and writer.
https://github.com/apache/groovy/blob/f3b6fdd794171fe8992b4024f881dec1c974f97a/src/main/java/org/codehaus/groovy/runtime/IOGroovyMethods.java#L1450
The `Writable filterLine(Reader,...)` variant does not say this. Maybe it
is enough to add a comment saying reader is not closed. The internal
`BufferedReader` only maintains a reference to the input reader and a char
array. The array will be GC'd when no references to the Writable AIC remain.
Is that not sufficient?
> File.filterLine leaves hanging Reader
> -------------------------------------
>
> Key: GROOVY-8373
> URL: https://issues.apache.org/jira/browse/GROOVY-8373
> Project: Groovy
> Issue Type: Bug
> Components: groovy-jdk
> Reporter: Tim Yates
> Priority: Trivial
>
> Looks like the default method for {{new File('.').filterLine}} creates a
> {{newReader}} which is never closed, nor is it accessible for the user to
> close it themselves.
> https://github.com/apache/groovy/blob/2d9c467ade68da0e3e73e64c4db7f29d742162f9/src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java#L2386
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
