[
https://issues.apache.org/jira/browse/GROOVY-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134562#comment-18134562
]
ASF GitHub Bot commented on GROOVY-12571:
-----------------------------------------
codecov-commenter commented on PR #3105:
URL: https://github.com/apache/groovy/pull/3105#issuecomment-6512517152
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3105?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.6788%. Comparing base
([`5b077f9`](https://app.codecov.io/gh/apache/groovy/commit/5b077f9dcf610898e3415f1f1cebbaab8eecab61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`43ec544`](https://app.codecov.io/gh/apache/groovy/commit/43ec544a542d0f1044604889d22b3f7e3964ed39?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3105 +/- ##
==================================================
+ Coverage 73.6711% 73.6788% +0.0077%
- Complexity 42584 42590 +6
==================================================
Files 1678 1678
Lines 146907 146916 +9
Branches 27790 27793 +3
==================================================
+ Hits 108228 108246 +18
+ Misses 28528 28519 -9
Partials 10151 10151
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3105?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../main/java/groovy/concurrent/BroadcastChannel.java](https://app.codecov.io/gh/apache/groovy/pull/3105?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fconcurrent%2FBroadcastChannel.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvY29uY3VycmVudC9Ccm9hZGNhc3RDaGFubmVsLmphdmE=)
| `78.2946% <100.0000%> (+4.4850%)` | :arrow_up: |
... and [15 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3105/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> BroadcastChannel.asPublisher() fails a subscriber that arrives after the
> broadcast closed
> -----------------------------------------------------------------------------------------
>
> Key: GROOVY-12571
> URL: https://issues.apache.org/jira/browse/GROOVY-12571
> Project: Groovy
> Issue Type: Bug
> Components: async
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import groovy.concurrent.BroadcastChannel
> def broadcast = BroadcastChannel.create()
> broadcast.close()
> for await (x in broadcast.asPublisher()) { println x } //
> ChannelClosedException; expected: ends without values
> {code}
> A subscriber that arrives after {{close()}} gets
> {{onError(ChannelClosedException)}}, and after {{close(failure)}} it gets the
> wrapper rather than the failure. A subscriber attached a moment before the
> close completes, or receives the failure itself, so the same program finishes
> or fails depending on timing. Expected: as {{SubmissionPublisher}},
> {{Agent.changes()}} and {{for await}} over a closed {{AsyncChannel}} behave,
> a late subscriber gets {{onComplete}} after {{close()}} and
> {{onError(failure)}} after {{close(failure)}}.
> {{BroadcastChannel.subscribe()}} still throws once closed.
> PR: https://github.com/apache/groovy/pull/3105
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
