[ 
https://issues.apache.org/jira/browse/GROOVY-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18138311#comment-18138311
 ] 

ASF GitHub Bot commented on GROOVY-12571:
-----------------------------------------

testlens-app[bot] commented on PR #3105:
URL: https://github.com/apache/groovy/pull/3105#issuecomment-6643031101

   ## ✅ All tests passed ✅
   
   🏷️ Commit: 1d4d420dbf775e607bf80e29ccb75bb64976e836
   ▶️ Tests:  114646 executed
   ⚪️ Checks: 26/26 completed
   
   ---
   _Learn more about TestLens at 
[testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   




> BroadcastChannel.asPublisher() fails a subscriber that arrives after the 
> broadcast closed
> -----------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12571
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12571
>             Project: Groovy
>          Issue Type: Bug
>          Components: async
>    Affects Versions: 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> {code:groovy}
> import groovy.concurrent.BroadcastChannel
> def broadcast = BroadcastChannel.create()
> broadcast.close()
> for await (x in broadcast.asPublisher()) { println x } // 
> ChannelClosedException; expected: ends without values
> {code}
> A subscriber that arrives after {{close()}} gets 
> {{onError(ChannelClosedException)}}, and after {{close(failure)}} it gets the 
> wrapper rather than the failure. A subscriber attached a moment before the 
> close completes, or receives the failure itself, so the same program finishes 
> or fails depending on timing. Expected: as {{SubmissionPublisher}}, 
> {{Agent.changes()}} and {{for await}} over a closed {{AsyncChannel}} behave, 
> a late subscriber gets {{onComplete}} after {{close()}} and 
> {{onError(failure)}} after {{close(failure)}}. 
> {{BroadcastChannel.subscribe()}} still throws once closed.
> Behaviour change from 6.0.0: code that caught {{ChannelClosedException}} from 
> a publisher of a closed broadcast now sees {{onComplete}} after {{close()}}, 
> or {{onError}} with the failure itself after {{close(failure)}}. The PR adds 
> a COMPATIBILITY.md entry.
> PR: https://github.com/apache/groovy/pull/3105



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to