[
https://issues.apache.org/jira/browse/GROOVY-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135499#comment-18135499
]
ASF GitHub Bot commented on GROOVY-12571:
-----------------------------------------
testlens-app[bot] commented on PR #3105:
URL: https://github.com/apache/groovy/pull/3105#issuecomment-6536894274
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3105`
#### [Build and test / lts \(17,
macos-latest\)](https://github.com/apache/groovy/actions/runs/41151300851/job/124388207458?pr=3105)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface\(\) | ❌ | 0% 🟢 |
🏷️ Commit: b92fe0de6568fc9d45ae6b851445f96ade63aab3
▶️ Tests: 70670 executed
🟡 Checks: 10/24 completed
### Test Failures
<details><summary><strong>MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface()</strong> (:test in
<a
href="https://github.com/apache/groovy/actions/runs/41151300851/job/124388207458?pr=3105";>Build
and test / lts (17, macos-latest)</a>)</summary>
```
java.lang.ClassFormatError: Method gstring$I$ctorRef$make$0$1 in class I has
illegal modifiers: 0x101A
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at groovy.lang.GroovyClassLoader.access$000(GroovyClassLoader.java:90)
at
groovy.lang.GroovyClassLoader$ClassCollector.createClass(GroovyClassLoader.java:1305)
at groovy.lang.GroovyClassLoader.collect(GroovyClassLoader.java:284)
at
groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:440)
at
groovy.lang.GroovyClassLoader.lambda$parseClass$2(GroovyClassLoader.java:378)
at
org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:143)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:378)
at groovy.lang.GroovyShell.parseClass(GroovyShell.java:664)
at groovy.lang.GroovyShell.parse(GroovyShell.java:677)
at groovy.lang.GroovyShell.parse(GroovyShell.java:689)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:551)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:107)
at
groovy.transform.stc.MethodReferenceTest.testMethodReferencesInStaticAndDefaultMethodsOfInterface(MethodReferenceTest.groovy:1613)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 MethodReferenceTest >
testMethodReferencesInStaticAndDefaultMethodsOfInterface\(\) <!
> BroadcastChannel.asPublisher() fails a subscriber that arrives after the
> broadcast closed
> -----------------------------------------------------------------------------------------
>
> Key: GROOVY-12571
> URL: https://issues.apache.org/jira/browse/GROOVY-12571
> Project: Groovy
> Issue Type: Bug
> Components: async
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import groovy.concurrent.BroadcastChannel
> def broadcast = BroadcastChannel.create()
> broadcast.close()
> for await (x in broadcast.asPublisher()) { println x } //
> ChannelClosedException; expected: ends without values
> {code}
> A subscriber that arrives after {{close()}} gets
> {{onError(ChannelClosedException)}}, and after {{close(failure)}} it gets the
> wrapper rather than the failure. A subscriber attached a moment before the
> close completes, or receives the failure itself, so the same program finishes
> or fails depending on timing. Expected: as {{SubmissionPublisher}},
> {{Agent.changes()}} and {{for await}} over a closed {{AsyncChannel}} behave,
> a late subscriber gets {{onComplete}} after {{close()}} and
> {{onError(failure)}} after {{close(failure)}}.
> {{BroadcastChannel.subscribe()}} still throws once closed.
> Behaviour change from 6.0.0: code that caught {{ChannelClosedException}} from
> a publisher of a closed broadcast now sees {{onComplete}} after {{close()}},
> or {{onError}} with the failure itself after {{close(failure)}}. The PR adds
> a COMPATIBILITY.md entry.
> PR: https://github.com/apache/groovy/pull/3105
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
