skrawcz commented on code in PR #1402:
URL: https://github.com/apache/hamilton/pull/1402#discussion_r2464521667
##########
contrib/docs/compile_docs.py:
##########
@@ -343,10 +343,12 @@ def _create_commit_file(df_path, single_df):
commit_path = df_path.replace("docs", "static/commits")
os.makedirs(commit_path, exist_ok=True)
with open(os.path.join(commit_path, "commit.txt"), "w") as f:
- for commit, ts in zip(
- single_df["__init__.py"]["commit"],
single_df["__init__.py"]["timestamp"]
- ):
- f.write(f"[commit::{commit}][ts::{ts}]\n")
+ f.writelines(
+ f"[commit::{commit}][ts::{ts}]\n"
+ for commit, ts in zip(
+ single_df["__init__.py"]["commit"],
single_df["__init__.py"]["timestamp"]
+ )
+ )
Review Comment:
this doesn't seem like a related change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
