Re: [PR] feat: Add support for loading context from TOML files including pyproject.toml [hamilton]

Sun, 26 Oct 2025 23:11:29 -0700 


skrawcz commented on code in PR #1402:
URL: https://github.com/apache/hamilton/pull/1402#discussion_r2464530454


##########
examples/LLM_Workflows/GraphRAG/ingest_notebook.ipynb:
##########
@@ -16,7 +16,8 @@
    "id": "4682d46e",
    "metadata": {},
    "source": [
-    "# Ingestion Notebook [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/ingest_notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/ingest_notebook.ipynb)\n",
+    "# Ingestion Notebook [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/ingest_notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/ingest_notebook.ipynb)
 [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples\\LLM_Workflows\\GraphRAG\\ingest_notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples\\LLM_Workflows\\GraphRAG\\ingest_notebook.ipynb)\n",

Review Comment:
   why is this updated? it seems to duplicate the badges?



##########
examples/LLM_Workflows/GraphRAG/notebook.ipynb:
##########
@@ -16,7 +16,8 @@
    "id": "cbd976a6",
    "metadata": {},
    "source": [
-    "# Question & answer notebook [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/notebook.ipynb)\n",
+    "# Question & answer notebook [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples/LLM_Workflows/GraphRAG/notebook.ipynb)
 [![Open In 
Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/dagworks-inc/hamilton/blob/main/examples\\LLM_Workflows\\GraphRAG\\notebook.ipynb)
 [![GitHub 
badge](https://img.shields.io/badge/github-view_source-2b3137?logo=github)](https://github.com/apache/hamilton/blob/main/examples\\LLM_Workflows\\GraphRAG\\notebook.ipynb)\n",

Review Comment:
   ditto duplication



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to