LiuTianyou commented on code in PR #2616:
URL: https://github.com/apache/hertzbeat/pull/2616#discussion_r1733158052
##########
manager/src/main/java/org/apache/hertzbeat/manager/controller/PluginController.java:
##########
@@ -85,4 +87,19 @@ public ResponseEntity<Message<Void>>
updatePluginStatus(@RequestBody PluginMetad
pluginService.updateStatus(plugin);
return ResponseEntity.ok(Message.success("Update success"));
}
+
+ @GetMapping("/getParamDefine")
+ @Operation(summary = "get param define", description = "get param define
by jar path")
+ public ResponseEntity<Message<PluginParametersVO>>
getParamDefine(@RequestParam Long pluginMetadataId) {
+ PluginParametersVO plugins =
pluginService.getParamDefine(pluginMetadataId);
+ return ResponseEntity.ok(Message.success(plugins));
+ }
+
+ @PostMapping("/saveParams")
Review Comment:
recommend to use all lowercase letters in the URL and use http method to
indicate the action such as replace `/getParamDefine` with `/params/define` and
replace '/saveParams` with `/params`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
