LiuTianyou commented on code in PR #2616:
URL: https://github.com/apache/hertzbeat/pull/2616#discussion_r1733173930
##########
manager/src/main/java/org/apache/hertzbeat/manager/service/PluginService.java:
##########
@@ -58,7 +63,7 @@ public interface PluginService {
* @param execute run plugin logic
* @param <T> plugin type
*/
- <T> void pluginExecute(Class<T> clazz, Consumer<T> execute);
+ <T> void pluginExecute(Class<T> clazz, Consumer<T> execute, BiConsumer<T,
List<Configmap>> biConsumer);
Review Comment:
It is recommended to wrap parameters in objects to improve the scalability
of the plugin interface and facilitate the subsequent transfer of other data to
the plugin for use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
