LiuTianyou commented on code in PR #2616:
URL: https://github.com/apache/hertzbeat/pull/2616#discussion_r1733175886
##########
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/PluginServiceImpl.java:
##########
@@ -73,17 +83,34 @@ public class PluginServiceImpl implements PluginService {
private final PluginItemDao itemDao;
+ private final PluginParamDao pluginParamDao;
+
public static Map<Class<?>, PluginType> PLUGIN_TYPE_MAPPING = new
HashMap<>();
/**
* plugin status
*/
private static final Map<String, Boolean> PLUGIN_ENABLE_STATUS = new
ConcurrentHashMap<>();
+ /**
+ * plugin param define
+ */
+ private static final Map<Long, List<ParamDefine>> PARAMS_Define_MAP = new
ConcurrentHashMap<>();
Review Comment:
`PARAMS_Define_MAP` Please use all uppercase letters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
