abhyudayareddy commented on PR #4104: URL: https://github.com/apache/hertzbeat/pull/4104#issuecomment-4426644405
@Duansg @zqr10159 — following up on my previous comment (no response since Apr 14). I want to make sure the distinction is clear: this PR monitors **external** Prometheus Remote Write receiver services (Thanos Receive, Cortex, Mimir, VictoriaMetrics) by checking their health/readiness endpoints (`/-/healthy`, `/ready`). It does **not** overlap with scraping a `/metrics` endpoint — that is a fundamentally different operation. `@zqr10159`'s comment that "these are clearly two different things" is exactly correct and actually supports the use case. On the YAML errors: `@Duansg` mentioned "numerous errors in the current template" but did not enumerate them. I am unable to fix errors I cannot see. Could you please: 1. List the specific fields or sections that are incorrect 2. 2. Point to an existing template that follows the correct pattern I am happy to rewrite the template from scratch to match HertzBeat conventions if given specific guidance. If the project does not want this type of monitoring template at all (policy decision), I will respect that — but if it is fixable, I would like to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
