ascherbakoff commented on a change in pull request #5935: IGNITE-11059 Log tx
lock timeout.
URL: https://github.com/apache/ignite/pull/5935#discussion_r253009442
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java
##########
@@ -1163,10 +1168,16 @@ private void loadMissingFromStore() {
/** {@inheritDoc} */
@Override public void onTimeout() {
- if (log.isDebugEnabled())
- log.debug("Timed out waiting for lock response: " + this);
-
synchronized (GridDhtLockFuture.this) {
+ if (log.isDebugEnabled() || timeout >= longOpDumpTimeout) {
+ String msg = "Timed out waiting for lock response, pending
locks: " + dump();
Review comment:
Better to dispose of string concatentation and use StringBuffer defined in
dump()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
