ascherbakoff commented on a change in pull request #5935: IGNITE-11059 Log tx
lock timeout.
URL: https://github.com/apache/ignite/pull/5935#discussion_r255020795
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/ContentionClosure.java
##########
@@ -105,6 +105,9 @@ public ContentionClosure(int minQueueSize, int maxPrint) {
catch (GridCacheEntryRemovedException ignored) {
cached =
entry.context().cache().entryEx(entry.key());
}
+ finally {
+ cached.touch();
Review comment:
It seems I was wrong and touch is not needed here, because it could trigger
various exceptions on tx prepare/lock acquisition. Touch will be called by code
handling the specific transaction. Please remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
