ascherbakoff commented on a change in pull request #5935: IGNITE-11059 Log tx
lock timeout.
URL: https://github.com/apache/ignite/pull/5935#discussion_r255024982
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/GridDhtLockFuture.java
##########
@@ -1154,6 +1157,11 @@ private void loadMissingFromStore() {
* Lock request timeout object.
*/
private class LockTimeoutObject extends GridTimeoutObjectAdapter {
+ /** */
+ final long longOpDumpTimeout = IgniteSystemProperties.getLong(
Review comment:
Adding long field overhead to every timeout object holding a constant looks
wrong.
Better add new property to IgniteTxManager and create getter/setter. For
example look at
org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager#slowTxWarnTimeout.
DFLT_LONG_OPERATIONS_DUMP_TIMEOUT will be not needed in such case (could be
defined in IgniteTxManager).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
