sk0x50 commented on a change in pull request #5779: IGNITE-10508 Support the
new checkpoint feature not wait for the previous operation to complete
URL: https://github.com/apache/ignite/pull/5779#discussion_r253441861
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/CheckpointHistory.java
##########
@@ -250,16 +255,27 @@ private FileWALPointer newerPointer(WALPointer
firstPointer, WALPointer secondPo
* @return Checkpoint mark until which checkpoints can be deleted(not
including this pointer).
*/
private WALPointer checkpointMarkUntilDeleteByMemorySize() {
- if (histMap.size() <= maxCpHistMemSize)
+ if (histMap.size() <= maxCpHistMemSize) {
+ log.info("None point to remove WAL, histMap=" + histMap.size() + "
maxCpHistMemSize=" + maxCpHistMemSize);
+
return null;
+ }
int calculatedCpHistSize = maxCpHistMemSize;
for (Map.Entry<Long, CheckpointEntry> entry : histMap.entrySet()) {
- if (histMap.size() <= calculatedCpHistSize++)
- return entry.getValue().checkpointMark();
+ if (histMap.size() <= calculatedCpHistSize++) {
+ CheckpointEntry e = entry.getValue();
+
+ log.info("WAL entry to remove, entry=" +e);
Review comment:
I think that `WAL entry to remove` is not quite enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
