sk0x50 commented on a change in pull request #5779: IGNITE-10508 Support the
new checkpoint feature not wait for the previous operation to complete
URL: https://github.com/apache/ignite/pull/5779#discussion_r253418120
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -2962,6 +2986,100 @@ private PartitionDestroyRequest cancelDestroy(int
grpId, int partId) {
return rmvd == null ? null : !rmvd.cancel() ? rmvd : null;
}
+
+ /**
+ *
+ */
+ public int size() {
+ return pendingReqs.size() + (prevDestroyQueue != null ?
prevDestroyQueue.size() : 0);
+ }
+
+ /**
+ *
+ */
+ private synchronized boolean isNotEmpty() {
Review comment:
Personally, I would prefer the name `isEmpty` instead of `isNotEmpty`. IMHO,
it looks more readable and familiar, of course, it's arguable. For example:
`!isNotEmpty()` looks like `not is not empty` which is odd to me :)
Anyway, it's up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
