sk0x50 commented on a change in pull request #5779: IGNITE-10508 Support the 
new checkpoint feature not wait for the previous operation to complete
URL: https://github.com/apache/ignite/pull/5779#discussion_r253443764
 
 

 ##########
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
 ##########
 @@ -1212,7 +1219,11 @@ private boolean copyPageForCheckpoint(
         try {
             long tmpRelPtr = PageHeader.tempBufferPointer(absPtr);
 
-            boolean success = clearCheckpoint(fullId);
+            boolean pageCopyed = false;
+
+            byte checkpointIdx = (byte)((tmpRelPtr & CHECKPOINT_INDEX_MASK) >> 
56);
 
 Review comment:
   I would prefer to have an appropriate method for that operation. I mean 
`getCheckointId(long tmpRelPtr)`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to