isapego commented on a change in pull request #7811: URL: https://github.com/apache/ignite/pull/7811#discussion_r427264493
########## File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Compute/IComputeClient.cs ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite.Core.Client.Compute +{ + using System; + using System.Threading; + using System.Threading.Tasks; + + /// <summary> + /// Client Compute API. See <see cref="IIgniteClient.GetCompute"/> + /// and <see cref="IClientClusterGroup.GetCompute"/>. + /// </summary> + public interface IComputeClient + { + /// <summary> + /// Executes Java task by class name. + /// </summary> + /// <param name="taskName">Java task name.</param> + /// <param name="taskArg">Optional argument of task execution, can be null.</param> + /// <returns>Task result.</returns> + /// <typeparam name="TRes">Type of task result.</typeparam> + TRes ExecuteJavaTask<TRes>(string taskName, object taskArg); Review comment: This is the only method of the class which is tested. Add at least tests for Async execution, WithKeepBinary... ########## File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/ClientSocket.cs ########## @@ -66,7 +66,7 @@ internal sealed class ClientSocket : IDisposable /** Current version. */ public static readonly ClientProtocolVersion CurrentProtocolVersion = Ver170; - + Review comment: Whitespace :) ########## File path: modules/platforms/dotnet/Apache.Ignite.Core.Tests/Client/Compute/ComputeClientDisabledTests.cs ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite.Core.Tests.Client.Compute +{ + using System; + using Apache.Ignite.Core.Client; + using Apache.Ignite.Core.Configuration; + using NUnit.Framework; + + /// <summary> + /// Tests client compute with disabled server-side settings. + /// </summary> + public class ComputeClientDisabledTests : ClientTestBase + { + /// <summary> + /// Tests that Compute throws correct exception when not enabled on server. + /// </summary> + [Test] + public void TestComputeThrowsCorrectExceptionWhenNotEnabledOnServer() Review comment: Can you add a more description in Doxy comment what do this test does? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
