ptupitsyn commented on a change in pull request #7811:
URL: https://github.com/apache/ignite/pull/7811#discussion_r427290313
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientClusterImpl.java
##########
@@ -132,7 +132,7 @@ private boolean changeWalState(String cacheName, boolean
enable) throws ClientEx
private void checkClusterApiSupported(ProtocolContext protocolCtx)
throws ClientFeatureNotSupportedByServerException {
if
(!protocolCtx.isFeatureSupported(ProtocolVersionFeature.CLUSTER_API) &&
-
!protocolCtx.isFeatureSupported(ProtocolBitmaskFeature.CLUSTER_API))
- throw new
ClientFeatureNotSupportedByServerException(ProtocolBitmaskFeature.CLUSTER_API);
+
!protocolCtx.isFeatureSupported(ProtocolBitmaskFeature.CLUSTER_ADDITIONAL_STATES))
+ throw new
ClientFeatureNotSupportedByServerException(ProtocolBitmaskFeature.CLUSTER_ADDITIONAL_STATES);
Review comment:
This entire method looks incorrect to me: `CLUSTER_STATES` flag is only
required for extra states, users should be able to use the API without this
flag.
However, this is out of scope of the current PR. Too much stuff here as it
is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
