ptupitsyn commented on a change in pull request #7811:
URL: https://github.com/apache/ignite/pull/7811#discussion_r427287054
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/client/compute/ClientExecuteTaskRequest.java
##########
@@ -77,7 +79,15 @@ public ClientExecuteTaskRequest(BinaryRawReader reader) {
long taskId = ctx.resources().put(task);
try {
- task.execute(taskId, taskName, arg, nodeIds, flags, timeout);
+ Object arg0 = arg;
+
+ // Deserialize as part of process() call - not in constructor -
for proper error handling.
+ // Failure to deserialize binary object should not be treated as a
failure to decode request.
+ if ((flags & ClientComputeTask.KEEP_BINARY_FLAG_MASK) == 0 && arg
instanceof BinaryObject) {
Review comment:
Fixed
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/MarshallerContextImpl.java
##########
@@ -391,34 +411,56 @@ public void onMappingAccepted(final MarshallerMappingItem
item) {
if (clsName != null)
cache.putIfAbsent(typeId, new MappedName(clsName, true));
else
- if (clientNode) {
- mappedName = cache.get(typeId);
-
- if (mappedName == null) {
- GridFutureAdapter<MappingExchangeResult> fut =
transport.requestMapping(
- new MarshallerMappingItem(platformId, typeId,
null),
- cache);
-
- clsName = fut.get().className();
- }
- else
- clsName = mappedName.className();
+ if (clientNode) {
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
