aleksey-kurinov commented on a change in pull request #7977:
URL: https://github.com/apache/ignite/pull/7977#discussion_r465166120
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/IgniteDiscoveryMassiveNodeFailTest.java
##########
@@ -301,15 +301,23 @@ public void testRecoveryOnDisconnect() throws Exception {
*
*/
private class FailDiscoverySpi extends TcpDiscoverySpi {
- /** {@inheritDoc} */
- @Override protected void writeToSocket(Socket sock,
TcpDiscoveryAbstractMessage msg, byte[] data,
+ /**
+ * Writes message to the socket.
+ *
+ * @param sock Socket.
+ * @param msg Message.
Review comment:
fixed. i've reviewd code obe more time and i've veririden method instead
of overloading. so doc is inherited now.
TcpDiscoveryConnectionCheckMessage is used as a stub instead of msg which
was pased via parameter according to your comment:
// Replace logic routine message with a stub to update last-sent-time to
avoid segmentation on
// connRecoveryTimeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]